Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DependencyInjection][ProxyManagerBridge] Added type-hints to LazyProxy classes and interfaces #32283

Merged

Conversation

Projects
None yet
4 participants
@derrabus
Copy link
Contributor

commented Jun 29, 2019

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #32179
License MIT
Doc PR N/A

This PR adds type-hints to the LazyProxy namespace of the DepenencyInjection component.

It also updates implementations of the LazyProxy interfaces inside the ProxyManager bridge. The consequence is that ProxyManagerBridge 5.0 won't work with DependencyInjection 4.4 anymore. If that is a problem, please tell me and I revert the ProxyManager part.

@derrabus derrabus referenced this pull request Jun 29, 2019

Open

[5.0] Add parameter type-hints #32179

43 of 57 tasks complete

@nicolas-grekas nicolas-grekas added this to the 5.0 milestone Jun 30, 2019

@derrabus derrabus force-pushed the derrabus:improvement/type-hints-on-lazy-proxy branch from ad12093 to 211b718 Jul 6, 2019

@nicolas-grekas
Copy link
Member

left a comment

OK, let's go.

@fabpot

fabpot approved these changes Jul 8, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

Thank you @derrabus.

@fabpot fabpot merged commit 211b718 into symfony:master Jul 8, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jul 8, 2019

minor #32283 [DependencyInjection][ProxyManagerBridge] Added type-hin…
…ts to LazyProxy classes and interfaces (derrabus)

This PR was merged into the 5.0-dev branch.

Discussion
----------

[DependencyInjection][ProxyManagerBridge] Added type-hints to LazyProxy classes and interfaces

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #32179
| License       | MIT
| Doc PR        | N/A

This PR adds type-hints to the LazyProxy namespace of the DepenencyInjection component.

It also updates implementations of the LazyProxy interfaces inside the ProxyManager bridge. The consequence is that ProxyManagerBridge 5.0 won't work with DependencyInjection 4.4 anymore. If that is a problem, please tell me and I revert the ProxyManager part.

Commits
-------

211b718 Added type-hints to LazyProxy classes and interfaces.

@derrabus derrabus deleted the derrabus:improvement/type-hints-on-lazy-proxy branch Jul 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.