Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] Add autowiring alias for PSR-14 #32295

Merged
merged 1 commit into from Jul 5, 2019

Conversation

Projects
None yet
5 participants
@nicolas-grekas
Copy link
Member

commented Jun 30, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -
@Tobion

This comment has been minimized.

Copy link
Member

commented Jun 30, 2019

I think requiring Psr\EventDispatcher would be developer friendlier. Currently developing against \Symfony\Contracts\EventDispatcher\EventDispatcherInterface is quite annoying because there are multiple definitions: one with and one without extending the PSR interface. In phpstorm you cannot simply follow the definition because it asks you to chose every time.

multiple-eventdispatcher

This was done because of the min php version requirement in psr/event-dispatcher, I see. I would suggest to create a minor release of https://packagist.org/packages/symfony/event-dispatcher-contracts that raises php requirement to 7.2 as well and requires psr/event-dispatcher. So people on PHP 7.1 would get the current version and php 7.2 and above the better DX.

@lyrixx

lyrixx approved these changes Jul 2, 2019

@Tobion

Tobion approved these changes Jul 5, 2019

@Tobion

This comment has been minimized.

Copy link
Member

commented Jul 5, 2019

Thank you @nicolas-grekas.

@Tobion Tobion merged commit 2d5bcda into symfony:4.4 Jul 5, 2019

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

Tobion added a commit that referenced this pull request Jul 5, 2019

feature #32295 [FrameworkBundle] Add autowiring alias for PSR-14 (nic…
…olas-grekas)

This PR was merged into the 4.4 branch.

Discussion
----------

[FrameworkBundle] Add autowiring alias for PSR-14

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

2d5bcda [FrameworkBundle] Add autowiring alias for PSR-14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.