Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DependencyInjection] Removed unused field #32306

Merged
merged 1 commit into from Jul 3, 2019

Conversation

@derrabus
Copy link
Contributor

commented Jul 1, 2019

Q A
Branch? 4.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets N/A
License MIT
Doc PR N/A

A minor issue I discovered while analyzing the DI component for #32238: AnalyzeServiceReferencesPass defines a private field $expressionLanguage that is not used.

@ro0NL

ro0NL approved these changes Jul 2, 2019

@lyrixx

lyrixx approved these changes Jul 2, 2019

Copy link
Member

left a comment

👍 Did you check for other unused property like that?

@ro0NL

This comment has been minimized.

Copy link
Contributor

commented Jul 2, 2019

Yes xD

@yceruto

yceruto approved these changes Jul 2, 2019

@xabbuh

xabbuh approved these changes Jul 2, 2019

@xabbuh xabbuh added this to the 4.2 milestone Jul 2, 2019

@fabpot

fabpot approved these changes Jul 3, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Jul 3, 2019

Thank you @derrabus.

@fabpot fabpot merged commit 5865140 into symfony:4.2 Jul 3, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jul 3, 2019

minor #32306 [DependencyInjection] Removed unused field (derrabus)
This PR was merged into the 4.2 branch.

Discussion
----------

[DependencyInjection] Removed unused field

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | N/A

A minor issue I discovered while analyzing the DI component for #32238: `AnalyzeServiceReferencesPass` defines a private field `$expressionLanguage` that is not used.

Commits
-------

5865140 Removed unused field.

@derrabus derrabus deleted the derrabus:bugfix/remove-unused branch Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.