Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workflow] only decorate when an event dispatcher was passed #32331

Merged
merged 1 commit into from Jul 3, 2019

Conversation

Projects
None yet
3 participants
@xabbuh
Copy link
Member

commented Jul 3, 2019

Q A
Branch? 4.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #32330
License MIT
Doc PR

@xabbuh xabbuh added this to the 4.3 milestone Jul 3, 2019

@xabbuh xabbuh requested a review from lyrixx as a code owner Jul 3, 2019

@lyrixx

lyrixx approved these changes Jul 3, 2019

@lyrixx

This comment has been minimized.

Copy link
Member

commented Jul 3, 2019

You were fast on this one, thanks Christian.

@lyrixx lyrixx merged commit f19f28a into symfony:4.3 Jul 3, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

lyrixx added a commit that referenced this pull request Jul 3, 2019

bug #32331 [Workflow] only decorate when an event dispatcher was pass…
…ed (xabbuh)

This PR was merged into the 4.3 branch.

Discussion
----------

[Workflow] only decorate when an event dispatcher was passed

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #32330
| License       | MIT
| Doc PR        |

Commits
-------

f19f28a only decorate when an event dispatcher was passed

@xabbuh xabbuh deleted the xabbuh:issue-32330 branch Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.