Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Messager] Simplified MessageBus::__construct() #32340

Merged
merged 1 commit into from Jul 3, 2019

Conversation

Projects
None yet
5 participants
@lyrixx
Copy link
Member

commented Jul 3, 2019

Q A
Branch? 4.3
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

The third path deals with generator (or other king of iterator that are

not an IteratorAggregate). It means, very few cases in practice

The previous code saved one object on the first call of self::dispatch()
by replacing it at runtime. More over, this object (anon. class) is very
light in memory.

The performance optimization (even if fun) is not useful here. Let's
make the code readable to everyone.

@lyrixx lyrixx requested a review from sroze as a code owner Jul 3, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Jul 3, 2019

That's for 4.4.

@nicolas-grekas nicolas-grekas added this to the next milestone Jul 3, 2019

[Messager] Simplified MessageBus::__construct()
The third path deals with generator (or other king of iterator that are
not an IteratorAggregate). It means, very few cases in practice

The previous code saved one object on the first call of `self::dispatch()`
by replacing it at runtime. More over, this object (anon. class) is very
light in memory.

The performance optimization (even if fun) is not useful here. Let's
make the code readable to everyone.

@lyrixx lyrixx force-pushed the lyrixx:messenger-message-bus-simplified branch from 8fcfcce to 6b5671f Jul 3, 2019

@lyrixx lyrixx requested review from dunglas and xabbuh as code owners Jul 3, 2019

@lyrixx

This comment has been minimized.

Copy link
Member Author

commented Jul 3, 2019

@fabpot PR updated.

@lyrixx lyrixx changed the base branch from 4.3 to 4.4 Jul 3, 2019

@fabpot

fabpot approved these changes Jul 3, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Jul 3, 2019

Thank you @lyrixx.

@fabpot fabpot merged commit 6b5671f into symfony:4.4 Jul 3, 2019

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jul 3, 2019

minor #32340 [Messager] Simplified MessageBus::__construct() (lyrixx)
This PR was merged into the 4.4 branch.

Discussion
----------

[Messager] Simplified MessageBus::__construct()

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

The third path deals with generator (or other king of iterator that are

not an IteratorAggregate). It means, very few cases in practice

The previous code saved one object on the first call of `self::dispatch()`
by replacing it at runtime. More over, this object (anon. class) is very
light in memory.

The performance optimization (even if fun) is not useful here. Let's
make the code readable to everyone.

Commits
-------

6b5671f [Messager] Simplified MessageBus::__construct()

@lyrixx lyrixx deleted the lyrixx:messenger-message-bus-simplified branch Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.