Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] reset in-memory caches between requests #32361

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@nicolas-grekas
Copy link
Member

commented Jul 4, 2019

Q A
Branch? 4.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Long-running kernels should reset in-memory caches between requests by default.

@nicolas-grekas

This comment has been minimized.

Copy link
Member Author

commented Jul 4, 2019

Replaced by #32363

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:fwb-cache-reset branch Jul 4, 2019

nicolas-grekas added a commit that referenced this pull request Jul 4, 2019

bug #32363 [FrameworkBundle] reset cache pools between requests (nico…
…las-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[FrameworkBundle] reset cache pools between requests

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Looks like we missed this part: cache pools should all be reset between requests, at least to persist any deferred items. Replaces #32361 (which should be applied when merging 3.4 into 4.2).

Commits
-------

5ff45ba [FrameworkBundle] reset cache pools between requests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.