Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] reset cache pools between requests #32363

Merged
merged 1 commit into from Jul 4, 2019

Conversation

Projects
None yet
2 participants
@nicolas-grekas
Copy link
Member

commented Jul 4, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Looks like we missed this part: cache pools should all be reset between requests, at least to persist any deferred items. Replaces #32361 (which should be applied when merging 3.4 into 4.2).

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:fwb-cache-reset34 branch from e1de717 to 5ff45ba Jul 4, 2019

@nicolas-grekas nicolas-grekas merged commit 5ff45ba into symfony:3.4 Jul 4, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Jul 4, 2019

bug #32363 [FrameworkBundle] reset cache pools between requests (nico…
…las-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[FrameworkBundle] reset cache pools between requests

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Looks like we missed this part: cache pools should all be reset between requests, at least to persist any deferred items. Replaces #32361 (which should be applied when merging 3.4 into 4.2).

Commits
-------

5ff45ba [FrameworkBundle] reset cache pools between requests

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:fwb-cache-reset34 branch Jul 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.