Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workflow] Add missing test for workflow dump description #32419

Conversation

Projects
None yet
4 participants
@alexislefebvre
Copy link
Contributor

commented Jul 7, 2019

Q A
Branch? 4.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

This PR add a test for a feature added in #29538 but missed a test.

@alexislefebvre alexislefebvre changed the title Add missing test for workflow dump description [Workflow] Add missing test for workflow dump description Jul 7, 2019

@alexislefebvre alexislefebvre force-pushed the alexislefebvre:add-missing-test-for-workflow-dump-description branch from f121fe2 to 1684e0b Jul 7, 2019

@lyrixx lyrixx added the Workflow label Jul 7, 2019

@lyrixx

lyrixx approved these changes Jul 7, 2019

@fabpot

fabpot approved these changes Jul 8, 2019

@fabpot fabpot changed the base branch from 4.4 to 4.3 Jul 8, 2019

@fabpot fabpot force-pushed the alexislefebvre:add-missing-test-for-workflow-dump-description branch from 1684e0b to 0c326d0 Jul 8, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

Thank you @alexislefebvre.

@fabpot fabpot merged commit 0c326d0 into symfony:4.3 Jul 8, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jul 8, 2019

minor #32419 [Workflow] Add missing test for workflow dump descriptio…
…n (alexislefebvre)

This PR was submitted for the 4.4 branch but it was merged into the 4.3 branch instead (closes #32419).

Discussion
----------

[Workflow] Add missing test for workflow dump description

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

This PR add a test for a feature added in #29538 but missed a test.

Commits
-------

0c326d0 Add missing test for workflow dump description

@alexislefebvre alexislefebvre deleted the alexislefebvre:add-missing-test-for-workflow-dump-description branch Jul 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.