Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ServerBundle] Display all logs by default #32423

Merged
merged 1 commit into from Jul 8, 2019

Conversation

Projects
None yet
4 participants
@lyrixx
Copy link
Member

commented Jul 8, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #32111
License MIT
Doc PR

Instead of relying on -vvv behavior, we display all logs.
End user has two ways of filtering now:

  • with the --filter options
  • by configuring the handler in config/dev/monolog.yaml
[ServerBundle] Display all logs by default
Instead of relying on `-vvv` behavior, we display all logs.
End user has two ways of filtering now (instead of 3 previously):

* with the `--filter` options
* by configuring the handler in `config/dev/monolog.yaml`

@nicolas-grekas nicolas-grekas changed the base branch from master to 4.4 Jul 8, 2019

@nicolas-grekas nicolas-grekas added this to the next milestone Jul 8, 2019

@nicolas-grekas
Copy link
Member

left a comment

(I did not run the code)

@fabpot

fabpot approved these changes Jul 8, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

Thank you @lyrixx.

@fabpot fabpot merged commit 54b0809 into symfony:4.4 Jul 8, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jul 8, 2019

feature #32423 [ServerBundle] Display all logs by default (lyrixx)
This PR was merged into the 4.4 branch.

Discussion
----------

[ServerBundle] Display all logs by default

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #32111
| License       | MIT
| Doc PR        |

Instead of relying on `-vvv` behavior, we display all logs.
End user has two ways of filtering now:

* with the `--filter` options
* by configuring the handler in `config/dev/monolog.yaml`

Commits
-------

54b0809 [ServerBundle] Display all logs by default

@lyrixx lyrixx deleted the lyrixx:server-log branch Jul 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.