Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console] don't redraw progress bar more than every 100ms by default #32424

Merged
merged 1 commit into from Jul 8, 2019

Conversation

Projects
None yet
3 participants
@nicolas-grekas
Copy link
Member

commented Jul 8, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? no (behavior change)
BC breaks? no (behavior change)
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Follow up of #26339
Looks like something we can and should do on 4.4 to me.

@nicolas-grekas nicolas-grekas added this to the next milestone Jul 8, 2019

@nicolas-grekas nicolas-grekas changed the title [Console] don't redraw progress bar more that ever 100ms by default [Console] don't redraw progress bar more that every 100ms by default Jul 8, 2019

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:console-refresh branch from b37628b to a19c068 Jul 8, 2019

@nicolas-grekas nicolas-grekas changed the title [Console] don't redraw progress bar more that every 100ms by default [Console] don't redraw progress bar more than every 100ms by default Jul 8, 2019

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:console-refresh branch from a19c068 to df551e9 Jul 8, 2019

@fabpot

fabpot approved these changes Jul 8, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

Thank you @nicolas-grekas.

@fabpot fabpot merged commit df551e9 into symfony:4.4 Jul 8, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jul 8, 2019

feature #32424 [Console] don't redraw progress bar more than every 10…
…0ms by default (nicolas-grekas)

This PR was merged into the 4.4 branch.

Discussion
----------

[Console] don't redraw progress bar more than every 100ms by default

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no (behavior change)
| BC breaks?    | no (behavior change)
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Follow up of #26339
Looks like something we can and should do on 4.4 to me.

Commits
-------

df551e9 [Console] don't redraw progress bar more than every 100ms by default

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:console-refresh branch Jul 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.