Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stopwatch] Fix missing deprecations #32428

Merged
merged 1 commit into from Jul 8, 2019

Conversation

Projects
None yet
5 participants
@yceruto
Copy link
Member

commented Jul 8, 2019

Q A
Branch? 4.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR no needed

Fix #32408

@fabpot

fabpot approved these changes Jul 8, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

Thank you @yceruto.

@fabpot fabpot merged commit 527bf89 into symfony:4.4 Jul 8, 2019

2 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jul 8, 2019

minor #32428 [Stopwatch] Fix missing deprecations (yceruto)
This PR was merged into the 4.4 branch.

Discussion
----------

[Stopwatch] Fix missing deprecations

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | no needed

Fix #32408

Commits
-------

527bf89 Fix missing deprecations

@yceruto yceruto deleted the yceruto:fix_32408 branch Jul 8, 2019

@@ -82,7 +82,7 @@ public function get($id)
*/
public function open($id)
{
if (null === $session = $this->get($id)) {
if (null === $id || null === $session = $this->get($id)) {

This comment has been minimized.

Copy link
@nicolas-grekas

nicolas-grekas Jul 11, 2019

Member

I'm reverting this change, it's a BC break caught by the test suite.

This comment has been minimized.

Copy link
@nicolas-grekas

nicolas-grekas added a commit that referenced this pull request Jul 11, 2019

minor #32494 [HttpKernel] fix tests (nicolas-grekas)
This PR was merged into the 3.4 branch.

Discussion
----------

[HttpKernel] fix tests

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This part of #32428 is for 3.4

Commits
-------

6eee2a8 [HttpKernel] fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.