Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VarDumper] Let browsers trigger their own search on double CMD/CTRL + F #32429

Merged

Conversation

Projects
None yet
4 participants
@ogizanagi
Copy link
Member

commented Jul 8, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29748
License MIT
Doc PR N/A

Simple way to enhance DX & mitigate #29748

@fabpot

fabpot approved these changes Jul 8, 2019

@ogizanagi ogizanagi force-pushed the ogizanagi:feat/var-dumper/browser-search-double-hit branch from b40ec21 to d243058 Jul 8, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

Thank you @ogizanagi.

@fabpot fabpot merged commit d243058 into symfony:4.4 Jul 8, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jul 8, 2019

feature #32429 [VarDumper] Let browsers trigger their own search on d…
…ouble CMD/CTRL + F (ogizanagi)

This PR was merged into the 4.4 branch.

Discussion
----------

[VarDumper] Let browsers trigger their own search on double CMD/CTRL + F

| Q             | A
| ------------- | ---
| Branch?       | 4.4 <!-- see below -->
| Bug fix?      | no
| New feature?  | yes <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #29748   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

Simple way to enhance DX & mitigate #29748

Commits
-------

d243058 [VarDumper] Let browsers trigger their own search on double CMD/CTRL + F hit

@ogizanagi ogizanagi deleted the ogizanagi:feat/var-dumper/browser-search-double-hit branch Jul 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.