Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing event_dispatcher wiring for messenger.middleware.send_message #32442

Conversation

Projects
None yet
5 participants
@weaverryan
Copy link
Member

commented Jul 8, 2019

Q A
Branch? 4.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #32375
License MIT
Doc PR not needed

This was probably my bad when I added this hook point (it's not used anywhere in the core). Also reported on Slack :).

Cheers!

@weaverryan weaverryan added this to the 4.3 milestone Jul 8, 2019

@weaverryan weaverryan added the Messenger label Jul 8, 2019

@xabbuh

xabbuh approved these changes Jul 9, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Jul 15, 2019

Thank you @weaverryan.

@nicolas-grekas nicolas-grekas merged commit 90d1b05 into symfony:4.3 Jul 15, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Jul 15, 2019

bug #32442 Adding missing event_dispatcher wiring for messenger.middl…
…eware.send_message (weaverryan)

This PR was merged into the 4.3 branch.

Discussion
----------

Adding missing event_dispatcher wiring for messenger.middleware.send_message

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #32375
| License       | MIT
| Doc PR        | not needed

This was probably my bad when I added this hook point (it's not used anywhere in the core). Also reported on Slack :).

Cheers!

Commits
-------

90d1b05 Adding missing event_dispatcher wiring for messenger.middleware.send_message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.