Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LDAP] add new option implemented in php 7.1 #32447

Merged
merged 1 commit into from Jul 12, 2019

Conversation

Projects
None yet
4 participants
@Simperfit
Copy link
Contributor

commented Jul 9, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #18448
License MIT
Doc PR none

Add new options to the LDAP connection class.

@Simperfit Simperfit force-pushed the Simperfit:feature/implement-new-ldap-option branch from ce14199 to 23edf1f Jul 9, 2019

@Simperfit

This comment has been minimized.

Copy link
Contributor Author

commented Jul 9, 2019

@nicolas-grekas nicolas-grekas added this to the next milestone Jul 10, 2019

@Simperfit Simperfit force-pushed the Simperfit:feature/implement-new-ldap-option branch from 23edf1f to d1a0ca6 Jul 11, 2019

@fabpot

fabpot approved these changes Jul 12, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Jul 12, 2019

Thank you @Simperfit.

@fabpot fabpot merged commit d1a0ca6 into symfony:4.4 Jul 12, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jul 12, 2019

minor #32447 [LDAP] add new option implemented in php 7.1 (Simperfit)
This PR was merged into the 4.4 branch.

Discussion
----------

[LDAP] add new option implemented in php 7.1

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | yes <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets |  #18448  <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | none <!-- required for new features -->

<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against branch 4.4.
 - Legacy code removals go to the master branch.
-->

Add new options to the LDAP connection class.

Commits
-------

d1a0ca6 [LDAP] add new option implemented in php 7.1

@Simperfit Simperfit deleted the Simperfit:feature/implement-new-ldap-option branch Jul 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.