Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing message parameter #32476

Merged
merged 1 commit into from Jul 12, 2019

Conversation

Projects
None yet
5 participants
@apfelbox
Copy link
Contributor

commented Jul 10, 2019

Q A
Branch? 4.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #32231 (comment)
License MIT
Doc PR

Add the missing parameter in the sprintf() call.

Found in #32231 (comment)

@apfelbox apfelbox force-pushed the apfelbox:ntlm-missing-param branch from e6e4a1d to a68d759 Jul 10, 2019

@apfelbox apfelbox force-pushed the apfelbox:ntlm-missing-param branch from a68d759 to a060642 Jul 10, 2019

@apfelbox

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2019

CI failures unrelated.

@nicolas-grekas this one should be ready.

@fabpot

fabpot approved these changes Jul 12, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Jul 12, 2019

Thank you @apfelbox.

@fabpot fabpot merged commit a060642 into symfony:4.4 Jul 12, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jul 12, 2019

minor #32476 Add missing message parameter (apfelbox)
This PR was merged into the 4.4 branch.

Discussion
----------

Add missing message parameter

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #32231 (comment)
| License       | MIT
| Doc PR        | —

<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against branch 4.4.
 - Legacy code removals go to the master branch.
-->

Add the missing parameter in the `sprintf()` call.

Found in #32231 (comment)

Commits
-------

a060642 Replace missing message parameter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.