Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] Added type declarations where possible #32480

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@derrabus
Copy link
Contributor

commented Jul 10, 2019

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #32179
License MIT
Doc PR N/A

@derrabus derrabus force-pushed the derrabus:improvements/framework-bundle-types branch from 2570663 to 377f5ed Jul 10, 2019

@nicolas-grekas nicolas-grekas added this to the 5.0 milestone Jul 11, 2019

@@ -77,7 +77,7 @@ protected function doWarmUp($cacheDir, ArrayAdapter $arrayAdapter)
return true;
}
private function readAllComponents(Reader $reader, $class)
private function readAllComponents(Reader $reader, string $class)

This comment has been minimized.

Copy link
@nicolas-grekas

nicolas-grekas Jul 11, 2019

Member

On private methods, this should be added to 4.4 - if we didn't do it in other PRs, we should backport as much as possible.

This comment has been minimized.

Copy link
@derrabus

derrabus Jul 11, 2019

Author Contributor

All right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.