Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Messenger] Allow exchange type headers binding #32489

Open
wants to merge 1 commit into
base: 4.4
from

Conversation

Projects
None yet
5 participants
@sroze
Copy link
Member

commented Jul 10, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29983
License MIT
Doc PR ø

Taken over #29983, as a feature for 4.4. Apparently useful.

@sroze

This comment has been minimized.

Copy link
Member Author

commented Jul 10, 2019

(failure is unrelated)

$dsn = 'amqp://localhost?'.
'exchange[default_publish_routing_key]=routing_key&'.
'queues[queue0][binding_arguments][x-match]=all';

This comment has been minimized.

Copy link
@Tobion

Tobion Jul 11, 2019

Member

x-match is for headers exchanges. but you are not defining a headers exchange. please make the test as real as possible even if mocked because otherwise it doesn't make sense for the reader.

This comment has been minimized.

Copy link
@sroze

sroze Jul 11, 2019

Author Member

Never had to use the queue binding arguments to be honest, but that's my understanding from this article:

A special argument named "x-match", which can be added in the binding between your exchange and your queue, tells if all headers must match or just one

This comment has been minimized.

Copy link
@Tobion

Tobion Jul 11, 2019

Member

as I said x-match only applies for HEADERS exchange. you are using the default direct exchange. you need to change the exchange type.

@sroze sroze force-pushed the sroze:amqp-bind-exchange-arguments branch from 6d482a5 to 195450e Jul 11, 2019

@nicolas-grekas nicolas-grekas added this to the next milestone Jul 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.