Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lock] remove deprecated Factory for LockFactory #32495

Conversation

Projects
None yet
5 participants
@Simperfit
Copy link
Contributor

commented Jul 11, 2019

Q A
Branch? 5.0
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets none
License MIT
Doc PR todo

This remove the deprecated Factory and changes the alias in FrameworkBundle.

Show resolved Hide resolved UPGRADE-5.0.md Outdated

@Simperfit Simperfit force-pushed the Simperfit:feature/remove-Factory-for-LockFactory branch from af09f0f to eb5d06c Jul 13, 2019

@xabbuh

xabbuh approved these changes Jul 13, 2019

@Simperfit Simperfit force-pushed the Simperfit:feature/remove-Factory-for-LockFactory branch from eb5d06c to 8bd805a Jul 17, 2019

/**
* @author Jérémy Derussé <jeremy@derusse.com>
*/
class FactoryTest extends TestCase

This comment has been minimized.

Copy link
@jderusse

jderusse Jul 18, 2019

Contributor

should be reverted (and renamed into LockFactoryTest)

This comment has been minimized.

Copy link
@jderusse

jderusse Jul 18, 2019

Contributor

nvm

@Simperfit

This comment has been minimized.

Copy link
Contributor Author

commented Jul 18, 2019

like @stof said, closing in favor of #32555 (this commits has been cherry-picked in the other PR)

@Simperfit Simperfit closed this Jul 18, 2019

@Simperfit Simperfit deleted the Simperfit:feature/remove-Factory-for-LockFactory branch Jul 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.