Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Messenger] DispatchAfterCurrentBusMiddleware does not cancel messages from delayed handlers #32497

Open
wants to merge 2 commits into
base: 4.3
from

Conversation

Projects
None yet
6 participants
@BastienClement
Copy link

commented Jul 11, 2019

Q A
Branch? 4.3 for bug fixes
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes (thanks @Nyholm)
Fixed tickets #32370
License MIT
Doc PR -

This is a fix for #32370. There is no need for anything sophisticated. There is no recursion or fancy stuff going on, just a queue of message handled sequentially. A simple variable is enough to keep track of the queue state.

Thanks @Nyholm for the test, it would clearly have been the hardest part of the job.

@BastienClement BastienClement force-pushed the BastienClement:issue-32370 branch from 94ccb43 to 1f5c8a6 Jul 11, 2019

@nicolas-grekas nicolas-grekas added this to the 4.3 milestone Jul 11, 2019

@weaverryan

This comment has been minimized.

Copy link
Member

commented Jul 14, 2019

Wdyt @Nyholm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.