Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Validator] remove invalid test cases #32498

Merged
merged 1 commit into from Jul 11, 2019

Conversation

Projects
None yet
3 participants
@xabbuh
Copy link
Member

commented Jul 11, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

@xabbuh xabbuh added this to the next milestone Jul 11, 2019

@xabbuh

This comment has been minimized.

Copy link
Member Author

commented Jul 11, 2019

same as #32249 and #32250 but with tests introduced in #31511

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit d7d2eac into symfony:4.4 Jul 11, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Jul 11, 2019

minor #32498 [Validator] remove invalid test cases (xabbuh)
This PR was merged into the 4.4 branch.

Discussion
----------

[Validator] remove invalid test cases

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

d7d2eac remove invalid test cases

@xabbuh xabbuh deleted the xabbuh:pr-31511 branch Jul 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.