Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[HttpClient] Allow enabling buffering based on the content-type of the response #32565
Thanks, LGTM for the component.
Could you please have a look at the configuration for the component in FrameworkBundle?
Jul 25, 2019
Right now the default value of the buffer option is true, defined in
Should I add this option in the configuration (both default_options and scoped_clients?) and validate it in the configuration?
Regex is nice to cover a lot of use case, I'm just wondering about the DX if this is the best option ?
If i want to create the regex that cover all of the text types it's not an easy one to create but this may be resolve by providing good examples in the documentation ?
(And providing some regex as constant to help for common use cases would even be better, but i think it's too soon to provide this, let's see how it is used before providing this)