Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip tests that fatal-error on PHP 7.4 because of missing parent classes #32864

Merged
merged 1 commit into from Aug 1, 2019

Conversation

@nicolas-grekas
Copy link
Member

commented Aug 1, 2019

Q A
Branch? 3.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #32844
License MIT
Doc PR -

See #32395 and https://bugs.php.net/78351 for more background.

This skips the affected tests with a warning, which means tests won't pass so we won't forget about them.

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Aug 1, 2019

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:php74-missing-parent branch from d861b33 to c2c7ba8 Aug 1, 2019

@nicolas-grekas nicolas-grekas merged commit c2c7ba8 into symfony:3.4 Aug 1, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Aug 1, 2019

minor #32864 Skip tests that fatal-error on PHP 7.4 because of missin…
…g parent classes (nicolas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

Skip tests that fatal-error on PHP 7.4 because of missing parent classes

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #32844
| License       | MIT
| Doc PR        | -

See #32395 and  https://bugs.php.net/78351 for more background.

This skips the affected tests with a warning, which means tests won't pass so we won't forget about them.

Commits
-------

c2c7ba8 Skip tests that fatal-error on PHP 7.4 because of missing parent classes

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:php74-missing-parent branch Aug 1, 2019

@nicolas-grekas nicolas-grekas referenced this pull request Aug 1, 2019
22 of 23 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.