Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt `@PHPUnit55Migration:risky` rule of php-cs-fixer #32884

Closed
wants to merge 1 commit into from

Conversation

@nicolas-grekas
Copy link
Member

commented Aug 2, 2019

Q A
Branch? 3.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

We might have to polyfill createPartialMock before merging this one.

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Aug 2, 2019

@@ -8,8 +8,7 @@ return PhpCsFixer\Config::create()
->setRules([
'@Symfony' => true,
'@Symfony:risky' => true,
'@PHPUnit48Migration:risky' => true,
'php_unit_no_expectation_annotation' => false, // part of `PHPUnitXYMigration:risky` ruleset, to be enabled when PHPUnit 4.x support will be dropped, as we don't want to rewrite exceptions handling twice
'@PHPUnit55Migration:risky' => true,

This comment has been minimized.

Copy link
@jderusse

jderusse Aug 2, 2019

Contributor

Can be PHPUnit75Migration:risky

php_unit_dedicate_assert should be configured to with target = 3.5 as all methods are not (yet) pollyfiled (ie assertDirectoryExist) in phpunit 4

@nicolas-grekas

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2019

Closing in favor of #32885

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:cs-phpunit55 branch Aug 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.