Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[Messenger] Added ErrorDetailsStamp #32904
This PR is part of the work started in #32341. That PR has a workaround for showing exceptions added to a previous retry. This PR stores error messages in a separate stamp, so they're more easily accessed.
I also added the exceptionClass as a separate string (independant of FlattenException), so that information is always available, even if the trace is not (due to FlattenException not being available).
Duplicated exceptions (compared to the last one) are not stored separately.
Also I think the error details stamp should be added by each retry (not just when failing at the end).
When we have the retry errors, the failed command should be able to list all the errors (not just diplay the last one).
With this feature added, the PR would actually give a nice DX improvement. Currently it's just a small refactoring without much gain for users.
Hi @Tobion, thank you for your review.
The idea for this PR is that it paves the way for a few follow-up PRs that include more changes and DX improvement (like a limit on the amount of error stamps). In order to keep this PR as small as possible (to make reviewing easier), @weaverryan and I decided to break the total work up in several separate PRs.
I'll look over your suggestions and rebase and make changes this week.