Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpClient] use "idle" instead of "inactivity" when telling about the timeout option #32928

Merged
merged 1 commit into from Aug 5, 2019

Conversation

@nicolas-grekas
Copy link
Member

commented Aug 4, 2019

Q A
Branch? 4.3
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

I feel like this might be easier to understand.
This is also the word I used in the doc.

@fabpot

fabpot approved these changes Aug 5, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Aug 5, 2019

Thank you @nicolas-grekas.

@fabpot fabpot merged commit d2c4bf0 into symfony:4.3 Aug 5, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Aug 5, 2019

minor #32928 [HttpClient] use "idle" instead of "inactivity" when tel…
…ling about the timeout option (nicolas-grekas)

This PR was merged into the 4.3 branch.

Discussion
----------

[HttpClient] use "idle" instead of "inactivity" when telling about the timeout option

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

I feel like this might be easier to understand.
This is also the word I used in the doc.

Commits
-------

d2c4bf0 [HttpClient] use "idle" instead of "inactivity" when telling about the timeout option

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:hc-idle branch Aug 5, 2019

@fancyweb fancyweb referenced this pull request Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.