Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Routing] Deprecate RouteCollectionBuilder #32937

Merged

Conversation

@vudaltsov
Copy link
Contributor

vudaltsov commented Aug 5, 2019

Q A
Branch? 5.1
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets #32240
License MIT
Doc PR symfony/symfony-docs#12688
Recipe PR symfony/recipes#690

A lot to be done here after the implementation is accepted:

  • finish deprecations in the MicroKernelTrait
  • deprecate the class
  • mention in the CHANGELOG file
  • mention in the UPGRADE file
  • mark tests as legacy
  • add a doc PR
  • update the recipe

Ping @Tobion , @nicolas-grekas .

@nicolas-grekas nicolas-grekas added this to the next milestone Aug 5, 2019
@vudaltsov vudaltsov changed the title [WIP] Deprecate RouteCollectionBuilder [Routing][WIP] Deprecate RouteCollectionBuilder Aug 5, 2019
@vudaltsov

This comment has been minimized.

Copy link
Contributor Author

vudaltsov commented Sep 3, 2019

@nicolas-grekas , @Tobion , could you please give me some feedback so that I can move on?

@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Sep 27, 2019

@Tobion would you have time to help move this one forward soonish? Otherwise, I'd suggest to close (and keep the issue open)

@Tobion

This comment has been minimized.

Copy link
Member

Tobion commented Oct 26, 2019

I won't be able to work on this as other issues have more priority to me like #33065 and #32077

@vudaltsov

This comment has been minimized.

Copy link
Contributor Author

vudaltsov commented Oct 26, 2019

@nicolas-grekas , don't close the PR, please. I will have time to make it ready for review soon. At least we'll discuss it at the hack day in Lisbon ;)

@vudaltsov vudaltsov force-pushed the vudaltsov:32240-deprecate-route-collection-builder branch from 570a239 to 16d5a6d Nov 10, 2019
@vudaltsov vudaltsov changed the base branch from 4.4 to master Nov 10, 2019
@vudaltsov vudaltsov marked this pull request as ready for review Nov 10, 2019
@vudaltsov vudaltsov changed the title [Routing][WIP] Deprecate RouteCollectionBuilder [Routing] Deprecate RouteCollectionBuilder Nov 10, 2019
@vudaltsov

This comment has been minimized.

Copy link
Contributor Author

vudaltsov commented Nov 10, 2019

@nicolas-grekas , ready for review with tests and deprecations!

I will finish the CHANGELOG and add the docs once you agree with the implementation.

For now I rebased onto master. Do we have any chance to get this in 4.4? Or it's too late?

@vudaltsov

This comment has been minimized.

Copy link
Contributor Author

vudaltsov commented Nov 24, 2019

@nicolas-grekas , fully ready for you review

Copy link
Member

nicolas-grekas left a comment

I really like the idea! Would be great to do the same for services late on ;)

@vudaltsov

This comment has been minimized.

Copy link
Contributor Author

vudaltsov commented Nov 24, 2019

Yes, I already started in the airplane yesterday ;)

UPGRADE-6.0.md Outdated Show resolved Hide resolved
@vudaltsov

This comment has been minimized.

Copy link
Contributor Author

vudaltsov commented Nov 25, 2019

@fabpot, thanx, corrected!

@fabpot
fabpot approved these changes Nov 25, 2019
@fabpot fabpot force-pushed the vudaltsov:32240-deprecate-route-collection-builder branch from badef1d to e641cbd Nov 25, 2019
@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Nov 25, 2019

Thank you @vudaltsov.

@fabpot fabpot closed this in 7719fc7 Nov 25, 2019
@fabpot fabpot merged commit e641cbd into symfony:master Nov 25, 2019
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details
@vudaltsov vudaltsov deleted the vudaltsov:32240-deprecate-route-collection-builder branch Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.