Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dotenv] support setting default env var values #32980

Merged
merged 1 commit into from Oct 9, 2019

Conversation

@xabbuh
Copy link
Member

commented Aug 6, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #31530
License MIT
Doc PR
@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

:= actually should assign too. I'm not sure we need it, since the same can be achieved using :-.

image

@nicolas-grekas nicolas-grekas force-pushed the xabbuh:issue-31530 branch from e65a77b to 2dd41e7 Oct 9, 2019
Copy link
Member

left a comment

(I fixed the implem)

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Oct 9, 2019

Thank you @xabbuh.

nicolas-grekas added a commit that referenced this pull request Oct 9, 2019
This PR was merged into the 4.4 branch.

Discussion
----------

[Dotenv] support setting default env var values

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #31530
| License       | MIT
| Doc PR        |

Commits
-------

2dd41e7 [Dotenv] support setting default env var values
@nicolas-grekas nicolas-grekas merged commit 2dd41e7 into symfony:4.4 Oct 9, 2019
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details
@xabbuh xabbuh deleted the xabbuh:issue-31530 branch Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.