Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lock] add type-hint whenever possible #33004

Closed

Conversation

@Simperfit
Copy link
Contributor

commented Aug 7, 2019

Q A
Branch? 5.0
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets Contribute to #32179
License MIT
Doc PR symfony/symfony-docs#...

Add type-hint in the lock component

@OskarStark

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2019

The fixed ticket should not include “t”

@derrabus derrabus referenced this pull request Aug 7, 2019
57 of 57 tasks complete

@nicolas-grekas nicolas-grekas added this to the 5.0 milestone Aug 7, 2019

@jderusse
Copy link
Contributor

left a comment

Could you please add acquire(bool $blocking = false) in LockInterface?

@nicolas-grekas
Copy link
Member

left a comment

(I'm taking care of the comments while merging)

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Aug 8, 2019

Thank you @Simperfit.

nicolas-grekas added a commit that referenced this pull request Aug 8, 2019

minor #33004 [Lock] add type-hint whenever possible (Simperfit)
This PR was merged into the 5.0-dev branch.

Discussion
----------

[Lock] add type-hint whenever possible

| Q             | A
| ------------- | ---
| Branch?       | 5.0
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? |no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | Contribute to #32179 <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against branch 4.4.
 - Legacy code removals go to the master branch.
-->
Add type-hint in the lock component

Commits
-------

a5ddab2 [Lock] add type-hint whenever possible
@Simperfit

This comment has been minimized.

Copy link
Contributor Author

commented Aug 8, 2019

thanks @nicolas-grekas for taking care of the comments!

@Simperfit Simperfit deleted the Simperfit:feature/add-type-hint-on-lock branch Aug 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.