Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded phpdocs #33019

Merged
merged 1 commit into from Aug 8, 2019

Conversation

@fabpot
Copy link
Member

commented Aug 7, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a
@lyrixx

lyrixx approved these changes Aug 7, 2019

@chalasr chalasr added this to the next milestone Aug 7, 2019

@nicolas-grekas nicolas-grekas force-pushed the fabpot:phpdocs-removal-again branch from 3273208 to 692a6e7 Aug 8, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Aug 8, 2019

Thank you @fabpot.

@nicolas-grekas nicolas-grekas merged commit 692a6e7 into symfony:4.4 Aug 8, 2019

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

nicolas-grekas added a commit that referenced this pull request Aug 8, 2019

minor #33019 Remove unneeded phpdocs (fabpot)
This PR was squashed before being merged into the 4.4 branch (closes #33019).

Discussion
----------

Remove unneeded phpdocs

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Commits
-------

692a6e7 Remove unneeded phpdocs
@kaznovac
Copy link
Contributor

left a comment

some impovements

* @param object $subject
* @param Marking $marking
* @param Transition $transition
* @param WorkflowInterface $workflow

This comment has been minimized.

Copy link
@kaznovac

kaznovac Aug 8, 2019

Contributor

$workflow is not typehinted in _constructor
possible types WorkflowInterface|string|null

* @param Definition $definition A Definition instance
* @param Marking|null $marking A Marking instance
* @param array $options An array of options
* @param array $options An array of options

This comment has been minimized.

Copy link
@kaznovac

kaznovac Aug 8, 2019

Contributor

can be removed

* @param string $class The class name of the loaded objects
* @param IdReader|null $idReader The reader for the object IDs
* @param EntityLoaderInterface|null $objectLoader The objects loader
* @param string $class The class name of the loaded objects

This comment has been minimized.

Copy link
@kaznovac

kaznovac Aug 8, 2019

Contributor

typehinted in constructor maybe surplus

@@ -133,7 +133,6 @@ protected function write($content, $decorated = false)
*
* @param Definition|Alias|object $service
* @param array $options

This comment has been minimized.

Copy link
@kaznovac

kaznovac Aug 8, 2019

Contributor

typehinted

* @param KernelInterface $kernel A KernelInterface instance
* @param TemplateNameParserInterface $parser A TemplateNameParserInterface instance
* @param string $rootDir The directory where global templates can be stored
* @param string $rootDir The directory where global templates can be stored

This comment has been minimized.

Copy link
@kaznovac

kaznovac Aug 8, 2019

Contributor

typehinted maybe needed

@@ -99,7 +99,6 @@ class NativeSessionStorage implements SessionStorageInterface
*
* @param array $options Session configuration options

This comment has been minimized.

Copy link
@kaznovac

kaznovac Aug 8, 2019

Contributor

no additional value

* @param Request $request The request the kernel is currently processing
* @param int $requestType The request type the kernel is currently processing; one of
* HttpKernelInterface::MASTER_REQUEST or HttpKernelInterface::SUB_REQUEST
* @param int $requestType The request type the kernel is currently processing; one of

This comment has been minimized.

Copy link
@kaznovac

kaznovac Aug 8, 2019

Contributor

int|null

* @param \DOMElement $node Element to parse
* @param string $path Full path of the XML file being processed
* @param string $file Loaded file name
* @param \DOMElement $node Element to parse

This comment has been minimized.

Copy link
@kaznovac

kaznovac Aug 8, 2019

Contributor

inferable

@@ -24,8 +24,7 @@ interface DumperInterface
/**
* Dumps the message catalogue.
*
* @param MessageCatalogue $messages The message catalogue
* @param array $options Options that are used by the dumper
* @param array $options Options that are used by the dumper

This comment has been minimized.

Copy link
@kaznovac

kaznovac Aug 8, 2019

Contributor

no additional value

* caused the violation
* @param mixed $cause The cause of the violation
* @param string $message The violation message
* @param string $messageTemplate The raw violation message

This comment has been minimized.

Copy link
@kaznovac

kaznovac Aug 8, 2019

Contributor

lots of |null types can be stated in doc ($message, $messageTemplate, $propertyPath)

nicolas-grekas added a commit that referenced this pull request Aug 8, 2019

minor #33056 cleanup remaining param $options and internal Intl FullT…
…ransformer (Tobion)

This PR was merged into the 4.4 branch.

Discussion
----------

cleanup remaining param $options and internal Intl FullTransformer

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets |#...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        |

Continuation of #33020 and #33019

Commits
-------

5dbcdc6 cleanup remaining param  and internal Intl FulLTransformer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.