Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpClient] Remove CURLOPT_CONNECTTIMEOUT_MS curl opt #33022

Merged
merged 1 commit into from Aug 8, 2019

Conversation

@lyrixx
Copy link
Member

commented Aug 7, 2019

Q A
Branch? 4.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #33017
License MIT
Doc PR -

@lyrixx lyrixx changed the base branch from master to 4.3 Aug 7, 2019

@nicolas-grekas nicolas-grekas added this to the 4.3 milestone Aug 7, 2019

@nicolas-grekas
Copy link
Member

left a comment

(failures unrelated)
We use the stream method internally, which also implements timeout management, but it reads network buffers before failing, which this option doesn't.

@lyrixx lyrixx force-pushed the lyrixx:http-client-connect branch from e1f9599 to 679ea90 Aug 7, 2019

@nicolas-grekas nicolas-grekas force-pushed the lyrixx:http-client-connect branch from 679ea90 to e289723 Aug 8, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Aug 8, 2019

Thank you @lyrixx.

@nicolas-grekas nicolas-grekas merged commit e289723 into symfony:4.3 Aug 8, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Aug 8, 2019

bug #33022 [HttpClient] Remove CURLOPT_CONNECTTIMEOUT_MS curl opt (ly…
…rixx)

This PR was merged into the 4.3 branch.

Discussion
----------

[HttpClient] Remove CURLOPT_CONNECTTIMEOUT_MS curl opt

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #33017
| License       | MIT
| Doc PR        | -

Commits
-------

e289723 [HttpClient] Remove CURLOPT_CONNECTTIMEOUT_MS curl opt

@lyrixx lyrixx deleted the lyrixx:http-client-connect branch Aug 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.