Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Debug compatibility layers #33027

Merged
merged 1 commit into from Aug 8, 2019

Conversation

@chalasr
Copy link
Member

commented Aug 7, 2019

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

@chalasr chalasr added this to the 5.0 milestone Aug 7, 2019

@chalasr chalasr force-pushed the chalasr:drop-debug-compat branch from c73262f to 7fc93e9 Aug 7, 2019

@yceruto

yceruto approved these changes Aug 7, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Aug 8, 2019

composer.json needs to be updated too, to remove the classmap entry

@fancyweb

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2019

@chalasr Line 137 in Console Application.php -> && !$phpHandler[0] instanceof LegacyErrorHandler

@chalasr chalasr force-pushed the chalasr:drop-debug-compat branch from 7fc93e9 to db0d29f Aug 8, 2019

@chalasr

This comment has been minimized.

Copy link
Member Author

commented Aug 8, 2019

@fancyweb fixed, thank you.

@nicolas-grekas if you mean the one added by #32873 (comment), it was reverted there

@chalasr chalasr force-pushed the chalasr:drop-debug-compat branch from db0d29f to 6b1b05e Aug 8, 2019

@chalasr

This comment has been minimized.

Copy link
Member Author

commented Aug 8, 2019

Removed the ProxiedMethodReturnExpression classmap entry

composer.json Outdated Show resolved Hide resolved

@chalasr chalasr force-pushed the chalasr:drop-debug-compat branch from 6b1b05e to 8e9bff5 Aug 8, 2019

@@ -134,7 +132,7 @@ public function run(InputInterface $input = null, OutputInterface $output = null
};
if ($phpHandler = set_exception_handler($renderException)) {
restore_exception_handler();
if (!\is_array($phpHandler) || (!$phpHandler[0] instanceof ErrorHandler && !$phpHandler[0] instanceof LegacyErrorHandler)) {
if (!\is_array($phpHandler) || (!$phpHandler[0] instanceof ErrorHandler)) {

This comment has been minimized.

Copy link
@nicolas-grekas

nicolas-grekas Aug 8, 2019

Member

extra brackets should be removed :)

This comment has been minimized.

Copy link
@chalasr

chalasr Aug 8, 2019

Author Member

right! done

@chalasr chalasr force-pushed the chalasr:drop-debug-compat branch from 8e9bff5 to 2326b80 Aug 8, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Aug 8, 2019

Thank you @chalasr.

@nicolas-grekas nicolas-grekas merged commit 2326b80 into symfony:master Aug 8, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Aug 8, 2019

minor #33027 Drop Debug compatibility layers (chalasr)
This PR was merged into the 5.0-dev branch.

Discussion
----------

Drop Debug compatibility layers

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against branch 4.4.
 - Legacy code removals go to the master branch.
-->

Commits
-------

2326b80 [Debug] Drop compatibility layers

@chalasr chalasr deleted the chalasr:drop-debug-compat branch Aug 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.