Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TwigBridge] Support for Twig 3 #33039

Draft
wants to merge 1 commit into
base: master
from

Conversation

@derrabus
Copy link
Contributor

commented Aug 8, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? yes
Deprecations? no
Tests pass? yes
Fixed tickets N/A
License MIT
Doc PR N/A

I occasionally test my projects against dev branches of the libraries I use. It's probably a bit early for this PR, but since I had to patch Symfony anyway in order to test Twig 3 in my projects, I though I might as well share the branch with you.

BC break: I had to add return types to several non-final classes of the Twig bridge. This will break applications that override these classes without adding the return types.

This PR is marked as a draft because Twig 3 is still a moving target.

@derrabus derrabus force-pushed the derrabus:improvement/twig-3 branch 2 times, most recently from 4bd824f to 0ea6aab Aug 8, 2019

@chalasr chalasr added this to the 5.0 milestone Aug 9, 2019

@derrabus derrabus force-pushed the derrabus:improvement/twig-3 branch from 0ea6aab to af7d80b Aug 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.