Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make HttpClientTestCase compatible with PHPUnit8 #33045

Merged

Conversation

@jderusse
Copy link
Contributor

commented Aug 8, 2019

Q A
Branch? 4.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #32844
License MIT
Doc PR NA

the abstract class HttpClientTestCase may be extends by end user and execute by both PHPUnit 8 and bellow. Adding a return typehint on it will force all users extending it to add it too and would be a BC Break.

Note. I don't know how to trigger a deprecation here and help user to add it.

@jderusse jderusse force-pushed the jderusse:compat-httpClientTestCase-phpunit8 branch 3 times, most recently from c8c717c to 84a6690 Aug 8, 2019

@nicolas-grekas nicolas-grekas changed the base branch from 4.4 to 4.3 Aug 8, 2019

@nicolas-grekas nicolas-grekas added this to the 4.3 milestone Aug 8, 2019

@jderusse jderusse force-pushed the jderusse:compat-httpClientTestCase-phpunit8 branch from 84a6690 to 55daf15 Aug 8, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Aug 8, 2019

Thank you @jderusse.

@nicolas-grekas nicolas-grekas merged commit 55daf15 into symfony:4.3 Aug 8, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Aug 8, 2019

bug #33045 Make HttpClientTestCase compatible with PHPUnit8 (jderusse)
This PR was merged into the 4.3 branch.

Discussion
----------

Make HttpClientTestCase compatible with PHPUnit8

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #32844
| License       | MIT
| Doc PR        | NA

the abstract class `HttpClientTestCase` may be extends by end user and execute by both PHPUnit 8 and bellow. Adding a return typehint on it will force all users extending it to add it too and would be a BC Break.

Note. I don't know how to trigger a deprecation here and help user to add it.

Commits
-------

55daf15 Fix compatibility with PHPUnit 8

@jderusse jderusse deleted the jderusse:compat-httpClientTestCase-phpunit8 branch Aug 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.