Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serializer] Fix negative DateInterval #33066

Merged
merged 1 commit into from Aug 9, 2019

Conversation

@jderusse
Copy link
Contributor

commented Aug 8, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #33052
License MIT
Doc PR NA

This PR adds support for negative and signed DateInterval

@jderusse jderusse force-pushed the jderusse:fix-negative-interval branch from c1e07f5 to fd58fe9 Aug 8, 2019

@yceruto yceruto added this to the 3.4 milestone Aug 8, 2019

@jderusse jderusse force-pushed the jderusse:fix-negative-interval branch from fd58fe9 to 5a25e10 Aug 8, 2019

@jderusse jderusse force-pushed the jderusse:fix-negative-interval branch from 5a25e10 to abb8a67 Aug 8, 2019

@fabpot

fabpot approved these changes Aug 9, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

Thank you @jderusse.

@fabpot fabpot merged commit abb8a67 into symfony:3.4 Aug 9, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Aug 9, 2019

bug #33066 [Serializer] Fix negative DateInterval (jderusse)
This PR was merged into the 3.4 branch.

Discussion
----------

[Serializer] Fix negative DateInterval

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #33052
| License       | MIT
| Doc PR        | NA

This PR adds support for negative and signed DateInterval

Commits
-------

abb8a67 Fix negative DateInterval
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.