Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unitialized variable in DeprecationErrorHandler #33087

Merged
merged 1 commit into from Aug 9, 2019

Conversation

@jderusse
Copy link
Contributor

commented Aug 9, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

In some case the variable isAtLeastPhpUnit83 were not initialized (see https://github.com/symfony/symfony/pull/33079/files#r312406060).
This PR initialize it when needed.

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

Thank you @jderusse.

@nicolas-grekas nicolas-grekas merged commit 310e5c7 into symfony:3.4 Aug 9, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
fabbot.io Some changes should be done to comply with our standards.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

nicolas-grekas added a commit that referenced this pull request Aug 9, 2019

minor #33087 Fix unitialized variable in DeprecationErrorHandler (jde…
…russe)

This PR was merged into the 3.4 branch.

Discussion
----------

Fix unitialized variable in DeprecationErrorHandler

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

In some case the variable `isAtLeastPhpUnit83` were not initialized (see https://github.com/symfony/symfony/pull/33079/files#r312406060).
This PR initialize it when needed.

Commits
-------

310e5c7 Fix unitialized variable in DeprecationErrorHandler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.