Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added `Process::getLastOutputTime()` method #33098

Merged
merged 1 commit into from Aug 18, 2019

Conversation

@connorhu
Copy link
Contributor

commented Aug 9, 2019

Q A
Branch? 4.4 for features
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #28026
License MIT
Doc PR -

@chalasr chalasr added this to the next milestone Aug 9, 2019

@chalasr chalasr added the Process label Aug 9, 2019

src/Symfony/Component/Process/Process.php Outdated Show resolved Hide resolved
@derrabus

This comment has been minimized.

Copy link
Contributor

commented Aug 11, 2019

The PR should target the 4.4 branch.

src/Symfony/Component/Process/CHANGELOG.md Outdated Show resolved Hide resolved
src/Symfony/Component/Process/Process.php Outdated Show resolved Hide resolved
@fabpot

fabpot approved these changes Aug 18, 2019

@fabpot fabpot force-pushed the connorhu:master branch from 0822371 to 6359145 Aug 18, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Aug 18, 2019

Thank you @connorhu.

fabpot added a commit that referenced this pull request Aug 18, 2019

feature #33098 added `Process::getLastOutputTime()` method (connorhu)
This PR was squashed before being merged into the 5.0-dev branch (closes #33098).

Discussion
----------

added `Process::getLastOutputTime()` method

| Q             | A
| ------------- | ---
| Branch?       | 4.4 for features
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #28026
| License       | MIT
| Doc PR        | -

Commits
-------

6359145 added `Process::getLastOutputTime()` method

@fabpot fabpot merged commit 6359145 into symfony:master Aug 18, 2019

0 of 3 checks passed

fabbot.io Some changes should be done to comply with our standards.
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@OskarStark

This comment has been minimized.

Copy link
Contributor

commented Aug 20, 2019

Why was this PR merged in master instead of 4.4?
The docs issue also mention 5.0-dev(which is correct, if master for the code is correct)

cc @nicolas-grekas

@fabpot

This comment has been minimized.

Copy link
Member

commented Aug 20, 2019

This was merged in master by mistake. I will cherry-pick the commit in 4.4. Thanks for the head up.

@OskarStark

This comment has been minimized.

Copy link
Contributor

commented Aug 20, 2019

Thanks, I will update the docs issue accordingly 👍

@connorhu

This comment has been minimized.

Copy link
Contributor Author

commented Aug 21, 2019

Thank you @fabpot

I'll keep an eye out for similar simple issues.

@fabpot

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

@connorhu If you have access to an Amazon AWS EC2 machine, you might want to have a look a #33183, I think this is mainly about figuring out how to get the credentials from a local storage (having a look at the PHP SDK might be enough).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.