Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Revert "bug #33092 [DependencyInjection] Improve an exception message" #33108
Why didn't you get the exception from
Aug 10, 2019
changed the title
Revert "bug #33092 [DependencyInjection] Improve an exception message…
Aug 11, 2019
@fabpot a stacktrace from the original issue would be helpful :) there are a few possible known suspects: https://github.com/symfony/symfony/search?l=PHP&q=%22Class+%25s+used+for+service+%25s+cannot+be+found.%22
the rationale isnt 100% clear to me, i.e. why exactly didnt we detect
So we may have somewhat of a chicken/egg situation, nevertheless the behavior change is real.
I guess the user may process such service IDs themselves (so we are as preservative as possible). For reproducible builds we don't involve class_exists (correct me if im wrong), as such we would make a big assumption on service IDs. Hence we provide an error as late as possible.
I can answer that: because we do not want any normalization logic around ids. We got rid of any when making them case sensitive and that reduced the complexity by a nice margin. We do not want to introduce it again in a different flavor.