Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpFoundation] some cleanups #33112

Merged
merged 1 commit into from Aug 11, 2019

Conversation

@nicolas-grekas
Copy link
Member

commented Aug 11, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

As found by @azjezz in #33088

@nicolas-grekas

This comment has been minimized.

Copy link
Member Author

commented Aug 11, 2019

Thank you @azjezz.

@nicolas-grekas nicolas-grekas merged commit f62a3c0 into symfony:4.4 Aug 11, 2019

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Aug 11, 2019

minor #33112 [HttpFoundation] some cleanups (azjezz)
This PR was merged into the 4.4 branch.

Discussion
----------

[HttpFoundation] some cleanups

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

As found by @azjezz in #33088

Commits
-------

f62a3c0 [HttpFoundation] some cleanups

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:hf-clean branch Aug 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.