Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form] fix return type on FormDataCollector #33120

Merged
merged 1 commit into from Aug 12, 2019

Conversation

@maxhelias
Copy link
Contributor

commented Aug 12, 2019

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

@maxhelias maxhelias force-pushed the maxhelias:fix-type-form branch from 90183df to a7f03fd Aug 12, 2019

@maxhelias maxhelias changed the base branch from master to 3.4 Aug 12, 2019

@maxhelias maxhelias changed the title [5.0][Form] fix return type on FormDataCollector [Form] fix return type on FormDataCollector Aug 12, 2019

@maxhelias maxhelias force-pushed the maxhelias:fix-type-form branch from a7f03fd to de6b9ef Aug 12, 2019

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Aug 12, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

Good catch, thanks @maxhelias.

@nicolas-grekas nicolas-grekas merged commit de6b9ef into symfony:3.4 Aug 12, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Aug 12, 2019

minor #33120 [Form] fix return type on FormDataCollector (maxhelias)
This PR was merged into the 3.4 branch.

Discussion
----------

[Form] fix return type on FormDataCollector

| Q             | A
| ------------- | ---
| Branch?       | master <!-- see below -->
| Bug fix?      | yes
| New feature?  |no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? |no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | -   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | - <!-- required for new features -->

<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against branch 4.4.
 - Legacy code removals go to the master branch.
-->

Commits
-------

de6b9ef [Form] fix return type on FormDataCollector

@maxhelias maxhelias deleted the maxhelias:fix-type-form branch Aug 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.