Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Messenger] make delay exchange and queues durable like the normal ones by default #33127

Merged
merged 1 commit into from Aug 18, 2019

Conversation

@Tobion
Copy link
Member

commented Aug 12, 2019

Q A
Branch? 4.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #32891
License MIT
Doc PR

This also imrproves BC of #32631 by only adding the new expiry argument in case the delay queue name was not overwritten using the options. I will remove the checks in 4.4 again. Please merge this PR before releasing the new 4.3 version so that 32631 and this PR are part of one release.

@fabpot

fabpot approved these changes Aug 13, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

@Tobion Tests seems broken by this change.

@Tobion Tobion force-pushed the Tobion:fix-durable-delay branch from d6434df to e5ecda6 Aug 13, 2019

@Tobion

This comment has been minimized.

Copy link
Member Author

commented Aug 13, 2019

Fixed the tests

@fabpot

This comment has been minimized.

Copy link
Member

commented Aug 18, 2019

Thank you @Tobion.

fabpot added a commit that referenced this pull request Aug 18, 2019

bug #33127 [Messenger] make delay exchange and queues durable like th…
…e normal ones by default (Tobion)

This PR was merged into the 4.3 branch.

Discussion
----------

[Messenger] make delay exchange and queues durable like the normal ones by default

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #32891
| License       | MIT
| Doc PR        |

This also imrproves BC of #32631 by only adding the new expiry argument in case the delay queue name was not overwritten using the options. I will remove the checks in 4.4 again. Please merge this PR before releasing the new 4.3 version so that 32631 and this PR are part of one release.

Commits
-------

e5ecda6 [Messenger] make delay exchange and queues durable like the normal ones by default

@fabpot fabpot merged commit e5ecda6 into symfony:4.3 Aug 18, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

@Tobion Tobion deleted the Tobion:fix-durable-delay branch Aug 18, 2019

fabpot added a commit that referenced this pull request Aug 21, 2019

minor #33245 [Messenger] remove patch release BC layer of durable and…
… expiring delay (Tobion)

This PR was merged into the 4.4 branch.

Discussion
----------

[Messenger] remove patch release BC layer of durable and expiring delay

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets |
| License       | MIT
| Doc PR        |

Removes the small BC layer of #33127 from 4.3 in 4.4

Commits
-------

d5aaf44 [Messenger] remove patch release BC layer of durable and expiring delay
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.