Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form] Add bool type to ChoiceListFactoryInterface::createView $label argument #33131

Merged

Conversation

@vudaltsov
Copy link
Contributor

commented Aug 12, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

Replaces #33074
Ping @nicolas-grekas , @Tobion , @yceruto .

@yceruto
Copy link
Member

left a comment

The next step would be to add the \TypeError in master/5.0, no?

@vudaltsov

This comment has been minimized.

Copy link
Contributor Author

commented Aug 12, 2019

The next step would be to add the \TypeError in master/5.0, no?

Yes, I will do that in #32237

@vudaltsov vudaltsov force-pushed the vudaltsov:choice-list-factory-phpdoc-fix branch from 073c248 to 8f5d1ca Aug 13, 2019

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Aug 13, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

Thank you @vudaltsov.

@nicolas-grekas nicolas-grekas merged commit 8f5d1ca into symfony:3.4 Aug 13, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Aug 13, 2019

minor #33131 [Form] Add bool type to ChoiceListFactoryInterface::crea…
…teView $label argument (vudaltsov)

This PR was merged into the 3.4 branch.

Discussion
----------

[Form] Add bool type to ChoiceListFactoryInterface::createView $label argument

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Replaces #33074
Ping @nicolas-grekas , @Tobion , @yceruto .

Commits
-------

8f5d1ca Add false type to ChoiceListFactoryInterface::createView $label argument

@vudaltsov vudaltsov deleted the vudaltsov:choice-list-factory-phpdoc-fix branch Aug 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.