Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI] deprecate support for non-object services #33137

Merged
merged 1 commit into from Aug 13, 2019

Conversation

@nicolas-grekas
Copy link
Member

commented Aug 13, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #32411
License MIT
Doc PR -

Follows #32432 /cc @derrabus
Prepares for adding the ?object return-type on master.

@nicolas-grekas

This comment has been minimized.

Copy link
Member Author

commented Aug 13, 2019

I didn't update the changelog because I think this is not common enough to require one. Also, this doesn't prevent private scalar services, because those don't get through the patched methods. That's why this won't break places where we do define scalar services.

@derrabus

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

Can we also deprecate scalars in Container::set() and ContainerBuilder::set()?

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:di-inline-no-scalar branch from e2196ad to 7c01c4c Aug 13, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member Author

commented Aug 13, 2019

Here you are :)

@nicolas-grekas nicolas-grekas merged commit 7c01c4c into symfony:4.4 Aug 13, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Aug 13, 2019

feature #33137 [DI] deprecate support for non-object services (nicola…
…s-grekas)

This PR was merged into the 4.4 branch.

Discussion
----------

[DI] deprecate support for non-object services

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #32411
| License       | MIT
| Doc PR        | -

Follows #32432 /cc @derrabus
Prepares for adding the `?object` return-type on master.

Commits
-------

7c01c4c [DI] deprecate support for non-object services

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:di-inline-no-scalar branch Aug 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.