Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Intl] Full alpha3 language support #33140

Merged
merged 1 commit into from Aug 18, 2019

Conversation

@ro0NL
Copy link
Contributor

commented Aug 13, 2019

Q A
Branch? 4.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #33136
License MIT
Doc PR symfony/symfony-docs#...

I'll validate some more cases with tests.

@ro0NL ro0NL force-pushed the ro0NL:lang-alpha3 branch from dcf3c88 to 17c25df Aug 13, 2019

@ro0NL ro0NL force-pushed the ro0NL:lang-alpha3 branch from 17c25df to 2e7dc3a Aug 13, 2019

@ro0NL ro0NL marked this pull request as ready for review Aug 13, 2019

@ro0NL

This comment has been minimized.

Copy link
Contributor Author

commented Aug 13, 2019

Ready. This PR updates the list of alpha3 language codes from 180 to 589. The old list only referenced the alpha3 codes with a alpha2 mapping.

@ro0NL ro0NL force-pushed the ro0NL:lang-alpha3 branch 3 times, most recently from 631a38d to 0dc55be Aug 14, 2019

@ro0NL ro0NL referenced this pull request Aug 14, 2019

@nicolas-grekas nicolas-grekas added this to the next milestone Aug 14, 2019

@ro0NL ro0NL force-pushed the ro0NL:lang-alpha3 branch from c0fce62 to 3ad5d3e Aug 14, 2019

@ro0NL

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2019

@TerjeBr i resolved all your reviews, i think we have to settle here for now :) Thanks for reviewing, much appreciated. If i forgot or overlooked any of your concerns still, let me know.

nicolas-grekas added a commit that referenced this pull request Aug 14, 2019

minor #33158 [Intl] Explicit check (ro0NL)
This PR was merged into the 3.4 branch.

Discussion
----------

[Intl] Explicit check

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

This avoids a little conflict with #33140

data is not impacted (today), but i like to make our data selection as explicit as possible and avoid ever pulling in `deprecated` or e.g. `legacy` languages.

Commits
-------

fbd4ce4 [Intl] Explicit check

@ro0NL ro0NL force-pushed the ro0NL:lang-alpha3 branch from 3ad5d3e to 748ee11 Aug 14, 2019

@ro0NL ro0NL force-pushed the ro0NL:lang-alpha3 branch from 748ee11 to 29aee2d Aug 14, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Aug 18, 2019

Thank you @ro0NL.

fabpot added a commit that referenced this pull request Aug 18, 2019

bug #33140 [Intl] Full alpha3 language support (ro0NL)
This PR was merged into the 4.4 branch.

Discussion
----------

[Intl] Full alpha3 language support

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #33136
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

I'll validate some more cases with tests.

Commits
-------

29aee2d [Intl] Full alpha3 language support

@fabpot fabpot merged commit 29aee2d into symfony:4.4 Aug 18, 2019

2 of 3 checks passed

fabbot.io Some changes should be done to comply with our standards.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ro0NL ro0NL deleted the ro0NL:lang-alpha3 branch Aug 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.