Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed markdown file #33142

Merged
merged 1 commit into from Aug 13, 2019

Conversation

@lyrixx
Copy link
Member

commented Aug 13, 2019

Q A
Branch? 3.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

@lyrixx lyrixx requested a review from dunglas as a code owner Aug 13, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

I should probably add a check on fabbot :)

@lyrixx

This comment has been minimized.

Copy link
Member Author

commented Aug 13, 2019

@fabpot Indeed. My IDE removes quite often trailing space when I open a new PR. At least this check will be awesome.
The command I used: fd .md | xargs sed -i 's/^[ \t]*$//;s/[ \t]*$//' (fd)
And for the syntax, I opened all files and checked by hand. My IDE highlight errror

@fabpot

fabpot approved these changes Aug 13, 2019

@fabpot fabpot force-pushed the lyrixx:changelog branch from 5a3c198 to 1369725 Aug 13, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

Thank you @lyrixx.

@fabpot fabpot merged commit 1369725 into symfony:3.4 Aug 13, 2019

0 of 3 checks passed

fabbot.io Some changes should be done to comply with our standards.
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

fabpot added a commit that referenced this pull request Aug 13, 2019

minor #33142 Fixed markdown file (lyrixx)
This PR was squashed before being merged into the 3.4 branch (closes #33142).

Discussion
----------

Fixed markdown file

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

1369725 Fixed markdown file

@lyrixx lyrixx deleted the lyrixx:changelog branch Aug 13, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

@lyrixx could you please have a look at tests? It looks like this change broke them.

@lyrixx

This comment has been minimized.

Copy link
Member Author

commented Aug 14, 2019

I will

@lyrixx

This comment has been minimized.

Copy link
Member Author

commented Aug 14, 2019

Sorry, for the delay, I was sleeping / commuting :)
I opened a new PR #33160 where I revert changes on fixtures files

nicolas-grekas added a commit that referenced this pull request Aug 14, 2019

minor #33160 Partially Revert "Remove trailing space in all markdown …
…files" (lyrixx)

This PR was merged into the 3.4 branch.

Discussion
----------

Partially Revert "Remove trailing space in all markdown files"

This reverts commit 5a3c198.

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #33142
| License       | MIT
| Doc PR        | -

Commits
-------

2aec7df Partially Revert "Remove trailing space in all markdown files"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.