Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter type leftovers #33154

Merged
merged 1 commit into from Aug 21, 2019

Conversation

@derrabus
Copy link
Contributor

commented Aug 13, 2019

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #32179
License MIT
Doc PR N/A

@derrabus derrabus force-pushed the derrabus:improvement/type-leftovers branch 2 times, most recently from 77f21ed to 772c6bb Aug 13, 2019

@derrabus

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2019

Status: Needs Work

@nicolas-grekas nicolas-grekas added this to the 5.0 milestone Aug 14, 2019

@derrabus derrabus force-pushed the derrabus:improvement/type-leftovers branch 5 times, most recently from cfe451f to 35ae2ad Aug 14, 2019

@derrabus derrabus force-pushed the derrabus:improvement/type-leftovers branch 2 times, most recently from e2b2e5a to 8c60600 Aug 15, 2019

@derrabus derrabus marked this pull request as ready for review Aug 15, 2019

@derrabus derrabus requested review from lyrixx, sroze and xabbuh as code owners Aug 15, 2019

@derrabus

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2019

Status: Needs Review

@derrabus derrabus force-pushed the derrabus:improvement/type-leftovers branch from 8c60600 to 89ef1df Aug 16, 2019

@derrabus derrabus force-pushed the derrabus:improvement/type-leftovers branch from 89ef1df to f0426a6 Aug 16, 2019

Tobion added a commit that referenced this pull request Aug 17, 2019

minor #33185 [Serializer] Add more parameter types (derrabus)
This PR was merged into the 5.0-dev branch.

Discussion
----------

[Serializer] Add more parameter types

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #32179
| License       | MIT
| Doc PR        | N/A

We missed quite a lot in the Serializer, so I decided to open a separate PR instead of merging the changes into #33154.

Commits
-------

73b17a8 [Serializer] Add more parameter types.

nicolas-grekas added a commit that referenced this pull request Aug 18, 2019

minor #33197 Fix some docblocks (derrabus)
This PR was merged into the 3.4 branch.

Discussion
----------

Fix some docblocks

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | N/A

Backports from #33154.

Commits
-------

df89373 Fix some docblocks.

@derrabus derrabus force-pushed the derrabus:improvement/type-leftovers branch 2 times, most recently from 2e58c60 to 41f8ee6 Aug 18, 2019

fabpot added a commit that referenced this pull request Aug 18, 2019

minor #33198 Add types to private and final methods (derrabus)
This PR was merged into the 4.4 branch.

Discussion
----------

Add types to private and final methods

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #32179
| License       | MIT
| Doc PR        | N/A

Backports from #33154.

Commits
-------

1b88067 Add types to private and final methods.
@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Aug 19, 2019

rebase unlocked.

@derrabus derrabus force-pushed the derrabus:improvement/type-leftovers branch from 41f8ee6 to ca86fc5 Aug 19, 2019

@derrabus

This comment has been minimized.

Copy link
Contributor Author

commented Aug 19, 2019

Ready.

@derrabus derrabus force-pushed the derrabus:improvement/type-leftovers branch from d8493b8 to 34eda04 Aug 21, 2019

@derrabus

This comment has been minimized.

Copy link
Contributor Author

commented Aug 21, 2019

Rebased. PR is ready.

@Tobion

Tobion approved these changes Aug 21, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

Thank you @derrabus.

nicolas-grekas added a commit that referenced this pull request Aug 21, 2019

minor #33154 Parameter type leftovers (derrabus)
This PR was merged into the 5.0-dev branch.

Discussion
----------

Parameter type leftovers

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #32179
| License       | MIT
| Doc PR        | N/A

Commits
-------

34eda04 Added more parameter type declarations.

@nicolas-grekas nicolas-grekas merged commit 34eda04 into symfony:master Aug 21, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
fabbot.io Your code looks good.
Details

@derrabus derrabus deleted the derrabus:improvement/type-leftovers branch Aug 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.