Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dispatched events really final #33297

Merged
merged 1 commit into from Sep 8, 2019

Conversation

@Tobion
Copy link
Member

commented Aug 22, 2019

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

Continuation of #33152 for master

@Tobion Tobion added this to the 5.0 milestone Aug 22, 2019

@Tobion Tobion force-pushed the Tobion:real-final-events branch from 6d000f2 to 9b22176 Aug 23, 2019

@ro0NL
Copy link
Contributor

left a comment

shouldnt we update tests in 4.4 also?

@Tobion

This comment has been minimized.

Copy link
Member Author

commented Sep 5, 2019

Extracted updating tests for 4.4 in #33482

nicolas-grekas added a commit that referenced this pull request Sep 6, 2019
minor #33482 fix tests mocking final events (Tobion)
This PR was merged into the 4.4 branch.

Discussion
----------

fix tests mocking final events

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        |

Fix tests in 4.4 extracted from #33297

Commits
-------

637461f fix tests mocking final events
@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Sep 6, 2019

rebase unlocked.

@Tobion Tobion force-pushed the Tobion:real-final-events branch from 9b22176 to b87d41d Sep 6, 2019

@Tobion

This comment has been minimized.

Copy link
Member Author

commented Sep 6, 2019

Rebased and tests pass

@Tobion Tobion force-pushed the Tobion:real-final-events branch from b87d41d to 11c83a2 Sep 6, 2019

@Tobion Tobion force-pushed the Tobion:real-final-events branch from 11c83a2 to 953057f Sep 6, 2019

@fabpot
fabpot approved these changes Sep 8, 2019
@fabpot

This comment has been minimized.

Copy link
Member

commented Sep 8, 2019

Thank you @Tobion.

fabpot added a commit that referenced this pull request Sep 8, 2019
minor #33297 Make dispatched events really final (Tobion)
This PR was merged into the 5.0-dev branch.

Discussion
----------

Make dispatched events really final

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets |
| License       | MIT
| Doc PR        |

Continuation of #33152 for master

Commits
-------

953057f Make dispatched events really final

@fabpot fabpot merged commit 953057f into symfony:master Sep 8, 2019

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

@Tobion Tobion deleted the Tobion:real-final-events branch Sep 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.