Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[Ldap] Add LDAP error codes to exceptions #28677 #33339
This PR ensures that an LdapException is only used when an LDAP
This PR ensures that an
Additionally silencing is added to ldap functions where missing.
I like your work but to me it’s a BC break not about the error code (which could be handled and deprecated first) but someone who is catching an LdapException now got a different one and the try catch doesn’t work as expected anymore...
This could be reworked b extending LdapException by the newly introduced exceptions which would be BC.
I first thought about it. Though if any of the new exceptions is thrown, the using software cannot work correctly nowadays (and I wanted to avoid extra work to fix the class hierarchy in Sf 5). Nevertheless, you are right, to completely keep the same behavior they should extend
Though that we have a valid scope is already ensured by the