Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Yaml] fix dumping not inlined scalar tag values #33377

Merged
merged 1 commit into from Aug 29, 2019
Merged

Conversation

@xabbuh
Copy link
Member

xabbuh commented Aug 29, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #33354
License MIT
Doc PR
@xabbuh xabbuh force-pushed the xabbuh:issue-33354 branch from 9baa828 to 390f4f4 Aug 29, 2019
@stof
stof approved these changes Aug 29, 2019
xabbuh added a commit that referenced this pull request Aug 29, 2019
This PR was merged into the 3.4 branch.

Discussion
----------

[Yaml] fix dumping not inlined scalar tag values

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #33354
| License       | MIT
| Doc PR        |

Commits
-------

390f4f4 fix dumping not inlined scalar tag values
@xabbuh xabbuh merged commit 390f4f4 into symfony:3.4 Aug 29, 2019
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details
@xabbuh xabbuh deleted the xabbuh:issue-33354 branch Aug 29, 2019
fabpot added a commit that referenced this pull request Sep 10, 2019
This PR was merged into the 3.4 branch.

Discussion
----------

[Yaml] don't dump a scalar tag value on its own line

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

This commit fine tunes the bugfix made in #33377 with the feedback provided in #33464 (comment).

Commits
-------

a549069 don't dump a scalar tag value on its own line
This was referenced Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.