Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PropertyInfo] Give precedence to constructor arguments over getters/setters #33416

Open
wants to merge 1 commit into
base: 4.3
from

Conversation

@SCIF
Copy link
Contributor

commented Sep 1, 2019

Q A
Branch? 4.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #33415
License MIT
Doc PR --

@SCIF SCIF force-pushed the SCIF:bugfix/#33415 branch from b72dbc1 to 7766ef6 Sep 2, 2019

@nicolas-grekas
Copy link
Member

left a comment

if it's a bug fix, it's for 4.3
if it's a BC break, 4.4 won't fit, neither master
we need to balance this /cc @dunglas

@SCIF SCIF force-pushed the SCIF:bugfix/#33415 branch from 7766ef6 to 4e691a0 Sep 8, 2019

@SCIF SCIF changed the base branch from 4.4 to 4.3 Sep 8, 2019

@SCIF

This comment has been minimized.

Copy link
Contributor Author

commented Sep 8, 2019

Hi @nicolas-grekas , I've changed base for this PR and fixed review notices.

@nicolas-grekas nicolas-grekas added this to the 4.3 milestone Sep 8, 2019

@nicolas-grekas nicolas-grekas changed the title Give precedence constructor argument over getters/setters [PropertyInfo] Give precedence constructor argument over getters/setters Sep 8, 2019

@nicolas-grekas nicolas-grekas changed the title [PropertyInfo] Give precedence constructor argument over getters/setters [PropertyInfo] Give precedence to constructor argument over getters/setters Sep 8, 2019

@nicolas-grekas nicolas-grekas changed the title [PropertyInfo] Give precedence to constructor argument over getters/setters [PropertyInfo] Give precedence to constructor arguments over getters/setters Sep 8, 2019

@nicolas-grekas nicolas-grekas requested a review from dunglas Sep 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.