Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MonologBridge] Add Mailer handler #33456

Merged
merged 1 commit into from Feb 8, 2020
Merged

Conversation

@BoShurik
Copy link
Contributor

BoShurik commented Sep 4, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #33209
License MIT
Doc PR -
@BoShurik BoShurik force-pushed the BoShurik:monolog-mailer-handler branch from bc44440 to ccb966b Sep 4, 2019
Copy link
Member

stof left a comment

Tests are missing

src/Symfony/Bridge/Monolog/Handler/MailerHandler.php Outdated Show resolved Hide resolved
src/Symfony/Bridge/Monolog/Handler/MailerHandler.php Outdated Show resolved Hide resolved
src/Symfony/Bridge/Monolog/Handler/MailerHandler.php Outdated Show resolved Hide resolved
@BoShurik BoShurik force-pushed the BoShurik:monolog-mailer-handler branch 3 times, most recently from ffd261e to 089d495 Sep 4, 2019
@BoShurik
Copy link
Contributor Author

BoShurik commented Sep 4, 2019

@stof done, but not sure why build fails. Looks like unrelated

@BoShurik BoShurik force-pushed the BoShurik:monolog-mailer-handler branch from 089d495 to bcd7bfd Sep 5, 2019
@nicolas-grekas nicolas-grekas added this to the next milestone Sep 6, 2019
@BoShurik BoShurik force-pushed the BoShurik:monolog-mailer-handler branch from bcd7bfd to 8de4820 Oct 24, 2019
@weaverryan weaverryan modified the milestones: next, 4.4 Oct 28, 2019
@weaverryan
Copy link
Member

weaverryan commented Oct 28, 2019

Proposing this for the 4.4 milestone so that this doesn't block Mailer as a first-class citizen in 4.4/5.0

@BoShurik BoShurik force-pushed the BoShurik:monolog-mailer-handler branch from 8de4820 to d481032 Oct 28, 2019
@nicolas-grekas nicolas-grekas changed the title Add monolog mailer handler [MonologBridge] Add Mailer handler Nov 5, 2019
@weaverryan weaverryan modified the milestones: 4.4, next Dec 2, 2019
@acasademont
Copy link
Contributor

acasademont commented Dec 12, 2019

Any news here? I guess a PR to monolog-bundle would be also needed?

@BoShurik
Copy link
Contributor Author

BoShurik commented Jan 15, 2020

@noniagriconomie Hi! Sorry for delay. I'll add changes by the end of the week

@BoShurik BoShurik force-pushed the BoShurik:monolog-mailer-handler branch from d481032 to 3798fcb Jan 16, 2020
@BoShurik BoShurik requested review from dunglas, lyrixx, sroze and xabbuh as code owners Jan 16, 2020
@BoShurik BoShurik changed the base branch from 4.4 to master Jan 16, 2020
@BoShurik BoShurik removed request for dunglas, lyrixx, sroze and xabbuh Jan 16, 2020
@BoShurik BoShurik force-pushed the BoShurik:monolog-mailer-handler branch from 3798fcb to 8d9a042 Jan 16, 2020
@BoShurik BoShurik force-pushed the BoShurik:monolog-mailer-handler branch from 8d9a042 to 5b7393b Jan 16, 2020
@BoShurik
Copy link
Contributor Author

BoShurik commented Jan 17, 2020

Needs a review

@fabpot
fabpot approved these changes Feb 8, 2020
@fabpot
Copy link
Member

fabpot commented Feb 8, 2020

Thank you @BoShurik.

fabpot added a commit that referenced this pull request Feb 8, 2020
This PR was merged into the 5.1-dev branch.

Discussion
----------

[MonologBridge] Add Mailer handler

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | yes <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #33209   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | - <!-- required for new features -->

<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against branch 4.4.
 - Legacy code removals go to the master branch.
-->

Commits
-------

5b7393b Add monolog mailer handler
@fabpot fabpot merged commit 5b7393b into symfony:master Feb 8, 2020
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.1 May 4, 2020
@fabpot fabpot mentioned this pull request May 5, 2020
@Schyzophrenic
Copy link

Schyzophrenic commented Jun 10, 2020

As many others, this is the last reason we use SwiftMailer. Is there any chance this will be merged into SF 4.4?

@fabpot
Copy link
Member

fabpot commented Jun 12, 2020

@Schyzophrenic No, new features are never backported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

10 participants
You can’t perform that action at this time.